Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canvas arguments out of order #904

Merged
merged 1 commit into from
Aug 20, 2018
Merged

canvas arguments out of order #904

merged 1 commit into from
Aug 20, 2018
+4 −4

Conversation

mcnuttandrew
Copy link
Contributor

Should address #903

benshope
benshope approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@benshope benshope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcnuttandrew mcnuttandrew merged commit c21c6e1 into uber:master Aug 20, 2018
@mcnuttandrew mcnuttandrew deleted the canvas-correction branch September 23, 2018 16:15
ayarcohaila pushed a commit to ayarcohaila/react-vis that referenced this pull request Jun 30, 2021
canvas arguments out of order (uber#904)
db02d5e
ayarcohaila added a commit to ayarcohaila/react-vis that referenced this pull request May 30, 2023
@ayarcohaila
canvas arguments out of order (uber#904)
9977fb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benshope benshope benshope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcnuttandrew @benshope