Add curves to LineSeriesCanvas #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump for review? |
benshope
approved these changes
Aug 10, 2018
| let line = d3Shape.line() | ||
| .x(row => x(row) + marginLeft) | ||
| .y(row => y(row) + marginTop); | ||
| if (curve !== null) { |
There was a problem hiding this comment.
could probably skip this outer check because of the inner ones
| .x(row => x(row) + marginLeft) | ||
| .y(row => y(row) + marginTop); | ||
| if (curve !== null) { | ||
| if (typeof curve === 'string' && d3Shape[curve]) { |
There was a problem hiding this comment.
nice that you're allowing string and function to be passed! could potentially skip all the if checks and reassignment to write this like d3Shape.line().x(row => x(row) + marginLeft).y(row => y(row) + marginTop).curve(d3Shape[curve] || curve || whateverTheDefaultValue) }
There was a problem hiding this comment.
The form of this is mostly just copying a similar function in the regular lineseries, i guess a future PR could clean this up by combining them into some sort of decorator?
ayarcohaila
pushed a commit
to ayarcohaila/react-vis
that referenced
this pull request
Jun 30, 2021
* Add curves to LineSeriesCanvas * my visual linter got turned off, extreme atom eyeroll * address comment
ayarcohaila
added a commit
to ayarcohaila/react-vis
that referenced
this pull request
May 30, 2023
* Add curves to LineSeriesCanvas * my visual linter got turned off, extreme atom eyeroll * address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #804