Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hovering example for heatmap series #1078

Merged
merged 3 commits into from
Jan 1, 2019

Conversation

mcnuttandrew
Copy link
Contributor

No description provided.

Copy link
Contributor

@benshope benshope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

/>
</XYPlot>
);
export default class HeatmapChart extends Component {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait until we're able to use hooks instead of making a class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍👍👍👍👍👍👍👍

{x: 3, y: 15, color: 12}
]}
/>
{value && <Hint value={value} />}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value !== false if value is a number since it could be zero

@mcnuttandrew mcnuttandrew merged commit 883e78f into uber:master Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants