Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CustomSVGSeries to use getX / getY #1051

Merged
merged 2 commits into from
Dec 31, 2018
Merged

Conversation

SinZ163
Copy link
Contributor

@SinZ163 SinZ163 commented Nov 23, 2018

I ran into this problem when I refactored my graphs to use getX / getY rather than previously data.map to conform to x and y keys, and in doing so made my icons disappear as they had NaN as their x and y.

This has been successful in fixing them.

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mcnuttandrew mcnuttandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. This is super reasonable! Would you mind adding an accessor to one of the example CustomSVGSeries in the showcase just so we can sanity check/test this behaviour?

@SinZ163
Copy link
Contributor Author

SinZ163 commented Nov 28, 2018

@mcnuttandrew Sorry for the delays, updated an example now

@mcnuttandrew mcnuttandrew merged commit c820b41 into uber:master Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants