Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install a pre-push hook for removing unpm #1026

Merged
merged 4 commits into from
Oct 30, 2018
Merged

Conversation

mcnuttandrew
Copy link
Contributor

It is really easy to accidentally break the react-vis build by forgetting to remove unpm delivered packages. This has happened many many times. This PR adds pre push hook stop unpm packages from entering a PR.

This can also be used to create other hooks (like a prepublish hook that we've sought for a long time).

I don't know too much about husky, but it looks legit and the folks who use it are credible. Let me know if you have any thoughts.

Copy link
Contributor

@benshope benshope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I was looking at the commit hooks situation and was going to use husky also, so I already know that's a good choice. Make sure the package addition is reflected in the npm lockfile also.

@mcnuttandrew mcnuttandrew merged commit ede6f8e into uber:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants