Install a pre-push hook for removing unpm #1026
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is really easy to accidentally break the react-vis build by forgetting to remove unpm delivered packages. This has happened many many times. This PR adds pre push hook stop unpm packages from entering a PR.
This can also be used to create other hooks (like a prepublish hook that we've sought for a long time).
I don't know too much about husky, but it looks legit and the folks who use it are credible. Let me know if you have any thoughts.