Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomSVGSeries and onNearestX on version 1.10.2 #870

Closed
fabienjuif opened this issue Jul 12, 2018 · 3 comments · Fixed by #874
Closed

CustomSVGSeries and onNearestX on version 1.10.2 #870

fabienjuif opened this issue Jul 12, 2018 · 3 comments · Fixed by #874

Comments

@fabienjuif
Copy link

I think this is a regression from 1.10.2 over 1.10.1.

onNearestX isn't triggered anymore on version 1.10.2.
Maybe this is related to the ref thing because I use stateless component.

I just try to revert back to 1.10.1 and it works.

@fabienjuif
Copy link
Author

I don't know why the ref thing would break onNearestX, but nevermind:

@markov00
Copy link
Contributor

I think it breaks the onNearestX is called from the onParentMouseMove events passed by the XYPlot mouse handler _mouseMoveHandler. The onParentMouseMove is triggered only to components which ref is saved into the xyplot has the series-index .
If my comments and solutions are right, this means that we are no more saving the series refs into the xyplot avoiding any calls to onNearestX etc calls.

@mcnuttandrew
Copy link
Contributor

mcnuttandrew commented Jul 13, 2018

I would accept a PR that adds a fix and regression test against this behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants