Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new as-based API #141

Merged
merged 10 commits into from
Dec 4, 2017
Merged

Implement new as-based API #141

merged 10 commits into from
Dec 4, 2017

Conversation

ZacSweers
Copy link
Collaborator

This implements a new AutoDispose API (again, but final this time!) around using the new as() operator.

Resolves #140

Other things:

  • Moves kotlin to the same name for shared semantics
  • Opportunistically updated a few dependencies

Now, the API is just

Observable.just(1)
    .as(autoDisposable(scope))
    .subscribe();

Or in Kotlin

Observable.just(1)
    .autoDisposable(scope)
    .subscribe();

@ZacSweers
Copy link
Collaborator Author

Note the RestrictTo error-prone check is disabled for now because it's totally broken (it thinks only the support library is allowed to use it)

@ZacSweers ZacSweers merged commit deab8fb into master Dec 4, 2017
@ZacSweers ZacSweers deleted the z/asConverter branch December 4, 2017 02:51
@ZacSweers ZacSweers mentioned this pull request Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants