Extract LifecycleScopeProvider to separate artifact #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is where OutsideScope exceptions can be thrown
tyvsmith
reviewed
Jul 26, 2018
| import org.junit.Test; | ||
|
|
||
| import static com.google.common.truth.Truth.assertThat; | ||
|
|
||
| public final class AutoDisposeAndroidPluginsTest { | ||
|
|
||
| @After public void tearDown() { | ||
| @Before @After public void tearDown() { |
There was a problem hiding this comment.
tearDown is probably a bad name if you're using this for before and after.
There was a problem hiding this comment.
Part of Part of 53772ce
tyvsmith
reviewed
Jul 26, 2018
| @@ -17,7 +33,7 @@ | |||
| @Documented | |||
| @Retention(RetentionPolicy.CLASS) | |||
| @Target(ElementType.TYPE) | |||
| @interface DoNotMock { | |||
| public @interface DoNotMock { | |||
There was a problem hiding this comment.
Can we avoid making this public, will show up on other folks classpaths and may be somewhat common?
There was a problem hiding this comment.
Talked offline, not really avoidable unfortunately unless we wanted to make it a separate compileOnly artifact
tyvsmith
reviewed
Jul 26, 2018
| import org.junit.Test; | ||
|
|
||
| import static com.google.common.truth.Truth.assertThat; | ||
|
|
||
| public final class AutoDisposePluginsTest { | ||
|
|
||
| @After public void tearDown() { | ||
| @Before @After public void tearDown() { |
There was a problem hiding this comment.
Same as other tearDown comment
tyvsmith
reviewed
Jul 26, 2018
| */ | ||
| @CheckReturnValue | ||
| inline fun <T> Flowable<T>.autoDisposable( | ||
| provider: com.uber.autodispose.lifecycle.LifecycleScopeProvider<*>): FlowableSubscribeProxy<T> |
tyvsmith
reviewed
Jul 26, 2018
| .autoDisposable(lifecycleScopeProvider) | ||
| .subscribe(o) | ||
|
|
||
| o.assertError { it is com.uber.autodispose.lifecycle.LifecycleNotStartedException } |
tyvsmith
reviewed
Jul 26, 2018
| lifecycleScopeProvider.stop() | ||
|
|
||
| // https://github.com/ReactiveX/RxJava/issues/5178 | ||
| // assertThat(o.isDisposed).isTrue() |
There was a problem hiding this comment.
We leave these to indicate what we would assert/expect there but can't due to the linked issue
tyvsmith
reviewed
Jul 26, 2018
| } | ||
|
|
||
| tasks.withType(JavaCompile) { | ||
| options.compilerArgs += ["-Xep:NullAway:ERROR", "-XepOpt:NullAway:AnnotatedPackages=com.uber"] |
There was a problem hiding this comment.
Outside the scope of this PR
tyvsmith
reviewed
Jul 26, 2018
|
|
||
| public final class LifecycleScopesTest { | ||
|
|
||
| // TODO |
tyvsmith
approved these changes
Jul 26, 2018
This simplifies the API a bit while also tightening the exception possibilities. We now use a null peekEvent() to determine it to be a non-started lifecycle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #197
This extracts
LifecycleScopeProviderand its friends to a separate artifact and makes it extendScopeProvider.It's a bit long, but each commit is tiny and easy to digest.
Changes worth documenting:
LifecycleScopeProvideris now in a separateautodispose-lifecycleartifact and extendsScopeProvider. The package name iscom.uber.autodispose.lifecycle.AutoDisposePluginshas moved toAutoDisposeLifecyclePluginssince all the configuration was for lifecycle behavior. We can always bringAutoDisposePluginsback to the main artifact separately in the future.OutsideLifecycleExceptionis nowOutsideScopeException, and was not moved to the new lifecycle artifact.LifecycleEndNotificationis no longer publicScopeUtil's lifecycle-related methods are now moved toLifecycleScopesTestLifecycleScopeProvideris moved to the new artifactautodispose-lifecycle-jdk8artifact with aDefaultLifecycleScopeProviderthat stubs adefaultimplementation forrequestScope()autodispose-lifecycle-ktxartifact with extension functions forLifecycleScopeProvider. This-ktxname will be applied to the other artifacts as well (planned before 1.0).LifecycleScopeProviderchanges:correspondingEventsnow returns a more specificFunctioncalledCorrespondingEventsFunction, which can only throw anOutsideScopeExceptionand simplifies the generics@Nullablerather than Jetbrains