Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ParallelFlowable #142

Closed
ZacSweers opened this issue Dec 4, 2017 · 4 comments
Closed

Support ParallelFlowable #142

ZacSweers opened this issue Dec 4, 2017 · 4 comments
Labels
Enhancement Help wanted Kotlin
Milestone
0.6.0

Comments

@ZacSweers
Copy link
Collaborator

ParallelFlowable is considered a 6th distinct type in RxJava, complete with its own as() operator. We should probably support it.

Scope would be:

  • Add to AutoDisposeConverter's supported interfaces
  • Add extension functions to kotlin (no need for a deprecated autoDisposeWith() version
  • Implementation, though I think we can just return AutoDisposingSubscriberImpl
    • If we do reuse it, we should add a isParallel() method so consumers can introspect it.
@ZacSweers ZacSweers added this to the 0.6.0 milestone Dec 4, 2017
@VisheshVadhera
Copy link
Contributor

Hey, can I open a PR for this one?

@ZacSweers
Copy link
Collaborator Author

Please do!

@VisheshVadhera
Copy link
Contributor

Hey, @hzsweers, do you believe there's a use case for isParallel() in AutoDisposingSubscriberImpl?

@ZacSweers
Copy link
Collaborator Author

let's leave it out for now

@VisheshVadhera VisheshVadhera mentioned this issue Jan 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Help wanted Kotlin
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@ZacSweers @VisheshVadhera