Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with use of internal package not allowed - conflicts with multiple repository names #535

Closed
jacobgreenleaf opened this issue Dec 5, 2017 · 2 comments

Comments

@jacobgreenleaf
Copy link

jacobgreenleaf commented Dec 5, 2017

Because zap can be imported both as go.uber.org/zap and github.com/uber-go/zap, the users of the latter can not build due to some places where /internal is used:

jacobg-C02RC3QCG8WM:onix jacobgreenleaf$ make
  GO BUILD (1.9.2 darwin/amd64)    onix
.../vendor/github.com/uber-go/zap/stacktrace.go:28:2: use of internal package not allowed
make: *** [onix] Error 1

I'm not sure if the right solution is to avoid using internal/ or just punt the issue to clients, however I am opening this ticket so that others know to use go.uber.org/zap import form only.

@jacobgreenleaf jacobgreenleaf changed the title Use of internal/ conflicts with multiple repository names Build fails with use of internal package not allowed - conflicts with multiple repository names Dec 5, 2017
@jacobgreenleaf
Copy link
Author

Addressed in the FAQ: "Your code shouldn't contain any references to github.com/uber-go/zap."

@tobya
Copy link

tobya commented Jul 21, 2019

A useful link to the FAQ page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants