This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Hack -> Config: add options to disable smart retry #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirg
reviewed
Aug 29, 2017
There was a problem hiding this comment.
I really wish we could make the default to be "smart-retry" disabled. And if we go that route we should rename the flag to "FlagEnableSmartRetry", etc.
The only trouble is for existing CGs, we will need to set the flag to 'true', because the behaviour is that if the owner-email does not have "+smartRetryDisable", then it is enabled! Is that doable?
tools/common/lib.go
Outdated
| if disableNackThrottling == "true" { | ||
|
|
||
| disableNackThrottling := c.Bool(common.FlagDisableNackThrottling) | ||
| if disableNackThrottling == true { |
There was a problem hiding this comment.
you could probably simply do:
if c.Bool(common.FlagDisableNackThrottling {
...
instead of assigning it to a separate variable just for checking, etc.
tools/common/lib.go
Outdated
| options[common.FlagDisableNackThrottling] = "true" | ||
| } | ||
|
|
||
| disableSmartRetry := c.Bool(common.FlagDisableSmartRetry) | ||
| if disableSmartRetry == true { |
kirg
reviewed
Aug 29, 2017
tools/common/lib.go
Outdated
| if c.Bool(common.FlagDisableSmartRetry) == true { | ||
| disableSmartRetry = "true" | ||
| } | ||
|
|
||
| options = make(map[string]string) | ||
| options[common.FlagDisableNackThrottling] = disableNackThrottling |
There was a problem hiding this comment.
couldn't you set this with one if-check?
if c.Bool(common.FlagDisableNackThrottling) {
options[common.FlagDisableNackThrottling] = "true"
}
etc
kirg
approved these changes
Sep 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.