This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
add metrics for zone failover mgr #156
Merged
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thuningxu
reviewed
Apr 19, 2017
common/metrics/defs.go
Outdated
| @@ -119,10 +119,13 @@ var GoRuntimeMetrics = map[MetricName]MetricType{ | |||
|
|
|||
| // Scope enum | |||
| const ( | |||
| // -- Operation scopes for ZoneFailoverManager (common) -- | |||
| ZoneFailoverMgrScope = iota | |||
|
|
|||
There was a problem hiding this comment.
It's strange you prepend to an enum instead of append to the bottom. Is there a specific reason?
There was a problem hiding this comment.
no specific reason, let me move it if it's causing confusion
thuningxu
approved these changes
Apr 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.