-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupiter: wrong orientation in thumbnail of portrait-mode jpg #783
Comments
There is a big image collection needs to be ingested and this may affect the collection. so |
@leahvanderjagt will send the link to the batch, and we will test and do spike to investigate the impact on this collection. |
@weiweishi Links to the batches: |
verified several portrait mode photos in this collection that they are not impacted. Remove this ticket from current sprint based on our discussion. @leahvanderjagt |
Note that the samples in Weiwei's set don't have the EXIF Orientation property set, so they are natively portrait mode. The fact that they work shows that this batch is ok (assuming the whole batch is consistent), but it leaves open the question whether images that use EXIF Orientation will be correctly handled. |
The question at this point is whether old mis-oriented EXIF images will produce good thumbnails if the derivatives are regenerated. If this can be confirmed, we just need to regenerate all thumbnails for these images. The scope of the current issue is to test the regeneration; if it's good, spin off another issue to script the regenerating. Timebox for investigation: 1/2 day |
When processing with Imagemagick convert, it looks like the |
Describe the bug
When a jpg using EXIF Orientation to express portrait mode is deposited, the thumbnail is rendered in landscape mode, i.e. it looks sideways with the top of the image to the left.
To Reproduce
Expected behavior
The thumbnail should be in portrait mode, with the statue's head at the top
Screenshots
Additional context
The example is from production ERA, and I've confirmed that the same thing happens in a fresh deposit in a dev instance of current master (8a7586e). The example jpg's EXIF properties have "Orientation: Right-top".
The text was updated successfully, but these errors were encountered: