Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupiter: wrong orientation in thumbnail of portrait-mode jpg #783

Closed
pbinkley opened this issue Jul 20, 2018 · 7 comments
Closed

Jupiter: wrong orientation in thumbnail of portrait-mode jpg #783

pbinkley opened this issue Jul 20, 2018 · 7 comments
Assignees
Labels

Comments

@pbinkley
Copy link
Member

Describe the bug
When a jpg using EXIF Orientation to express portrait mode is deposited, the thumbnail is rendered in landscape mode, i.e. it looks sideways with the top of the image to the left.

To Reproduce

  1. Download this image from ERA
  2. Deposit it into a current Jupiter instance

Expected behavior
The thumbnail should be in portrait mode, with the statue's head at the top

Screenshots
volodya

Additional context
The example is from production ERA, and I've confirmed that the same thing happens in a fresh deposit in a dev instance of current master (8a7586e). The example jpg's EXIF properties have "Orientation: Right-top".

@pbinkley pbinkley added the bug label Jul 20, 2018
@weiweishi weiweishi changed the title wrong orientation in thumbnail of portrait-mode jpg Jupiter: wrong orientation in thumbnail of portrait-mode jpg Aug 8, 2018
@weiweishi
Copy link
Contributor

There is a big image collection needs to be ingested and this may affect the collection. so
@leahvanderjagt will send the link to the batch so we can test objects with portrait orientation to see if this affects them. If so, this becomes a higher priority.

@weiweishi
Copy link
Contributor

@leahvanderjagt will send the link to the batch, and we will test and do spike to investigate the impact on this collection.

@leahvanderjagt
Copy link

leahvanderjagt commented Sep 25, 2018

@weiweishi
Copy link
Contributor

verified several portrait mode photos in this collection that they are not impacted.
https://drive.google.com/open?id=11eBLhVbdUqVYs_03yNjq1WjNSYAUPObn
https://drive.google.com/file/d/1XReW8h5_lLt8DWwnoU54QqhkRcrrAMvG/view
https://drive.google.com/file/d/15HKBaS-IDyGCyOcKW9xz96SuH7xFSOtq/view

Remove this ticket from current sprint based on our discussion. @leahvanderjagt

@pbinkley
Copy link
Member Author

pbinkley commented Oct 4, 2018

Note that the samples in Weiwei's set don't have the EXIF Orientation property set, so they are natively portrait mode. The fact that they work shows that this batch is ok (assuming the whole batch is consistent), but it leaves open the question whether images that use EXIF Orientation will be correctly handled.

@pbinkley
Copy link
Member Author

pbinkley commented Oct 5, 2018

The question at this point is whether old mis-oriented EXIF images will produce good thumbnails if the derivatives are regenerated. If this can be confirmed, we just need to regenerate all thumbnails for these images. The scope of the current issue is to test the regeneration; if it's good, spin off another issue to script the regenerating.

Timebox for investigation: 1/2 day

@pbinkley
Copy link
Member Author

pbinkley commented Jan 3, 2019

When processing with Imagemagick convert, it looks like the -auto-orient flag will take care of orienting the image according to the EXIF orientation: http://www.imagemagick.org/script/command-line-options.php#auto-orient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants