bring in and enforce inclusive language cops #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorSheremeta
requested review from
jefferya,
lagoan,
murny and
pgwillia
as code owners
jefferya
reviewed
Aug 22, 2024
README.md
Outdated
| @@ -79,7 +79,7 @@ Some alternatives is you may also use the `localhost` top level domain (e.g: you | |||
| # UAT Environment | |||
|
|
|||
| The UAT server is accessible on all library staff workstation, and through VPN on any external IP address. More details regarding access and deployment can be found: | |||
| [Jupiter UAT Setup](https://github.com/ualbertalib/di_internal/blob/master/System-Adminstration/UAT/UAT-Environment.md) | |||
| [Jupiter UAT Setup](https://github.com/ualbertalib/di_internal/blob/master/System-Administration/UAT/UAT-Environment.md) | |||
There was a problem hiding this comment.
Update to new repository name this instance and on L282?
Suggested change
| [Jupiter UAT Setup](https://github.com/ualbertalib/di_internal/blob/master/System-Administration/UAT/UAT-Environment.md) | |
| [Jupiter UAT Setup](https://github.com/ualbertalib/library_applications_development/blob/main/System-Administration/UAT/UAT-Environment.md) |
There was a problem hiding this comment.
Good catch!
app/models/jupiter_core/search.rb
Outdated
| @@ -1,6 +1,6 @@ | |||
| class JupiterCore::Search | |||
|
|
|||
| # How dumb is this? Seems pretty dumb, but that's the official recommendation I guess: | |||
| # How unintelligent is this? Seems pretty unintelligent, but that's the official recommendation I guess: | |||
| # https://wiki.apache.org/solr/CommonQueryParameters | |||
There was a problem hiding this comment.
Original URL is no longer active for the older version of Solr. Suggestion, the IA version?
Suggested change
| # https://wiki.apache.org/solr/CommonQueryParameters | |
| # https://web.archive.org/web/20190405125211/https://wiki.apache.org/solr/CommonQueryParameters |
There was a problem hiding this comment.
Good catch and suggestion of leveraging IA 👍
bin/predeploy
Outdated
| @@ -2,15 +2,15 @@ | |||
|
|
|||
| # This script will be sitting in /home/deploy directory, and is for setting up directories and pulling required files for docker deployment | |||
| # This script should be either rsynced or copied to the UAT server when setting up fresh server. | |||
| # For more information, please see the documentation: https://github.com/ualbertalib/di_internal/blob/master/System-Adminstration/UAT-Environment.md | |||
| # For more information, please see the documentation: https://github.com/ualbertalib/di_internal/blob/master/System-Administration/UAT-Environment.md | |||
There was a problem hiding this comment.
Suggested change
| # For more information, please see the documentation: https://github.com/ualbertalib/di_internal/blob/master/System-Administration/UAT-Environment.md | |
| # For more information, please see the documentation: (https://github.com/ualbertalib/library_applications_development/blob/main/System-Administration/UAT/UAT-Environment.md> |
app/models/jupiter_core/search.rb
Outdated
| @@ -1,6 +1,6 @@ | |||
| class JupiterCore::Search | |||
|
|
|||
| # How dumb is this? Seems pretty dumb, but that's the official recommendation I guess: | |||
| # How unintelligent is this? Seems pretty unintelligent, but that's the official recommendation I guess: | |||
There was a problem hiding this comment.
My personal preference, remove the commentary, something like the following. Feel free to ignore this suggestion.
Suggested change
| # How unintelligent is this? Seems pretty unintelligent, but that's the official recommendation I guess: | |
| # official recommendation to return all results in a single page: set to number higher than possible number of results |
There was a problem hiding this comment.
Yeah, agreed. Remove the rant and just clean this up 😄
jefferya
reviewed
Aug 22, 2024
.rubocop.yml
Outdated
Comment on lines
11
to
13
| # TODO: update reference once merged. | ||
| inherit_from: | ||
| - https://raw.githubusercontent.com/ualbertalib/library_applications_development_inclusive_language/cds/initial-commit/inclusive_language_rubocop.yml |
There was a problem hiding this comment.
Leaving a comment at the "TODO"
|
Updated with feedback. Once this is merged dependabot should work as expected (#3543 (comment)) because of this change: jupiter/.github/dependabot.yml Line 10 in 10414f4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ualbertalib/library_applications_development/issues/100