Bump rubocop from 0.93.1 to 1.8.0 #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
dependabot-preview
bot
requested review from
ConnorSheremeta,
lagoan,
mbarnett,
murny and
pgwillia
as code owners
dependabot-preview
bot
added
dependencies
ruby
dependabot-preview
bot
force-pushed
the
dependabot/bundler/rubocop-1.8.0
branch
from
e8fa518 to
b12ece6
Compare
pgwillia
reviewed
Jan 7, 2021
| - bin/yarn | ||
|
|
||
| Naming/VariableNumber: |
There was a problem hiding this comment.
Naming/VariableNumber: Use normalcase for symbol numbers. (https://rubystyle.guide#snake-case-symbols-methods-vars-with-numbers). But we use normalcase most of the time and snake_case for the http status codes and licenses. Don't think its a big deal to mix these so ignoring.
| @@ -63,7 +63,7 @@ def edit; end | |||
|
|
|||
| def update | |||
| if params[:community][:logo].present? | |||
| # Note: monkey patch to ActiveStorage removes any previous versions | |||
| # NOTE: monkey patch to ActiveStorage removes any previous versions | |||
There was a problem hiding this comment.
Style/CommentAnnotation: Annotation keywords like Note should be all upper case, followed by a colon, and a space, then a note describing the problem. (https://rubystyle.guide#annotate-keywords)
| @@ -1,5 +1,6 @@ | |||
| # Some useful errors | |||
| class Exporters::Solr::IndexRoleInvalidError < StandardError; end | |||
|
|
|||
There was a problem hiding this comment.
Layout/EmptyLineBetweenDefs: Use empty lines between class definitions. (https://rubystyle.guide#empty-lines-between-methods)
pgwillia
force-pushed
the
dependabot/bundler/rubocop-1.8.0
branch
from
c4db9ac to
4492c9d
Compare
pgwillia
reviewed
Jan 7, 2021
| @@ -12,8 +12,7 @@ | |||
| b.optional :min_max | |||
| b.optional :readonly | |||
|
|
|||
| b.use :label, class: 'col-form-label' do | |||
| end | |||
| b.use :label, class: 'col-form-label' | |||
There was a problem hiding this comment.
Lint/EmptyBlock: Empty block detected.
murny
approved these changes
Jan 7, 2021
murny
previously approved these changes
Jan 11, 2021
pgwillia
force-pushed
the
dependabot/bundler/rubocop-1.8.0
branch
from
fb665ab to
7492c4c
Compare
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.93.1 to 1.8.0. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v0.93.1...v1.8.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Rubocop released 1.0 in October and have been moving quickly with updates. Seems stable at this point and worth updating. Style/CommentAnnotation: Annotation keywords like Note should be all upper case, followed by a colon, and a space, then a note describing the problem. (https://rubystyle.guide#annotate-keywords) Naming/VariableNumber: Use normalcase for symbol numbers. (https://rubystyle.guide#snake-case-symbols-methods-vars-with-numbers). But we use normalcase most of the time and snake_case for the http status codes and licenses. Don't think its a big deal to mix these so ignoring. Layout/EmptyLineBetweenDefs: Use empty lines between class definitions. (https://rubystyle.guide#empty-lines-between-methods) Lint/EmptyBlock: Empty block detected.
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop from 0.93.1 to 1.8.0.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
Commits
0af1a84Cut 1.80073a14Update Changeloga2d7e0aImprove handling of comments in ClassMethodsDefinition autocorrection3fea162[Fix #9233] Improve handling of comments in SoleNestedConditional autocorrection9eb5dafUpdateStyle/SingleLineMethodsto correct to an endless method definition i...1063b4e[Fix #9337] AddAllowedIdentifierstoNaming/VariableName.b734f24Use IRB instead of Pry653df19[Fix #9335] Fix an incorrect auto-correct forNestedParenthesizedCallse2718b4[Fix #9333] Fix an error forStyle/IfInsideElsec0d28efAdd newLint/DeprecatedConstantscopDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: