Turn off reporting this meaningless warning to Rollbar

[mbarnett]

Context

Rollbar is kind of unusable right now if you don't filter out warnings, because we send a ActiveStorage::UnrepresentableError warning every time someone views an item that has a file as its "logo" which isn't able to be turned into a thumbnail. The problem is that this is in almost all cases totally normal – we know that you can't thumbnail an Excel Spreadsheet, and we have a fallback to display a generic logo for these cases, so this doesn't need to be reported.

What's New

Tell Rollbar gem to stop reporting this error.

Other Options

I'm also somewhat tempted to remove this:

jupiter/app/helpers/page_layout_helper.rb

Lines 52 to 53 in 34b64ff

	logger.warn("#{logo.record_type} with id: #{logo.record_id} and thumbnail #{logo.name} threw an error.")
	Rollbar.warn("#{logo.record_type} with id: #{logo.record_id} and thumbnail #{logo.name} threw an error.", e)

which warns when a jpg or png or whatever can't be thumbnailed because it's unparseable/corrupted – this is a real error, but there's really nothing we can or do do to resolve this, so it just seems like noise. Thoughts?

[murny]

LGTM 👍

For your question:

which warns when a jpg or png or whatever can't be thumbnailed because it's unparseable/corrupted – this is a real error, but there's really nothing we can or do do to resolve this, so it just seems like noise. Thoughts?

If there's nothing we can do to fix these issues, then yeah it's just noise. Do these types of issues happen a lot? is there a reason they are unparsable/corrupted?

If there is literally nothing we can do on our side and we just ignore them anyways, then absolutely, not much worth alerting us to these issues if we can't do anything to fix them. So make sense to just disable 🤔.

[mbarnett]

Put it this way, we've recorded 3,724 MiniMagick::Invalid: improper image header errors in the last 2 years, and that's just one variant that crops up for PNGs.

I think there are under a hundred items with corrupt images, but they tend to get crawled regularly, so they're noisy-ish

edit: would be good to audit them somehow and just hand a list off to Leah/Sean/Metadata and get them cleaned up. Should be pretty doable

[murny]

Yeah makes sense and probably best path forward regarding create a list for product owners to go through for auditing and try to fix the issue 👍

[mbarnett]

I'll throw a ticket in the backlog for it