Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.3.2 to 2.4.1 #1398

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps rubocop-rails from 2.3.2 to 2.4.1.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.4.1

Bug fixes

  • #170: Make Rails/BulkChangeTable not suggest combining methods with an intervening block. (@mvz)
  • #159: Fix autocorrect for Rails/EnumHash when using % arrays notations. (@ngouy)

Changes

  • #166: Add db/schema.rb and bin/* to the excluded files. (@fidalgo)

RuboCop Rails 2.4.0

New features

  • #123: Add new Rails/ApplicationController and Rails/ApplicationMailer cops. (@eugeneius)
  • #130: Add new Rails/RakeEnvironment cop. (@pocke)
  • #133: Add new Rails/SafeNavigationWithBlank cop. (@gyfis)

Bug fixes

  • #120: Fix message for Rails/SaveBang when the save is in the body of a conditional. (@jas14)
  • #131: Fix an incorrect autocorrect for Rails/Presence when using [] method. (@forresty)
  • #142: Fix an incorrect autocorrect for Rails/EnumHash when using nested constants. (@koic)
  • #136: Fix a false positive for Rails/ReversibleMigration when using change_default with :from and :to options. (@sinsoku)
  • #144: Fix a false positive for Rails/ReversibleMigration when using change_table_comment or change_column_comment with a :from and :to hash. (@DNA)

Changes

  • #156: Make Rails/UnknownEnv cop aware of Rails.env == 'unknown_env'. (@pocke)
  • #141: Change default of EnforcedStyle from arguments to slashes for Rails/FilePath. (@koic)
Changelog

Sourced from rubocop-rails's changelog.

2.4.1 (2019-12-25)

Bug fixes

  • #170: Make Rails/BulkChangeTable not suggest combining methods with an intervening block. ([@mvz][])
  • #159: Fix autocorrect for Rails/EnumHash when using % arrays notations. ([@ngouy][])

Changes

  • #166: Add db/schema.rb and bin/* to the excluded files. ([@fidalgo][])

2.4.0 (2019-11-27)

New features

  • #123: Add new Rails/ApplicationController and Rails/ApplicationMailer cops. ([@eugeneius][])
  • #130: Add new Rails/RakeEnvironment cop. ([@pocke][])
  • #133: Add new Rails/SafeNavigationWithBlank cop. ([@gyfis][])

Bug fixes

  • #120: Fix message for Rails/SaveBang when the save is in the body of a conditional. ([@jas14][])
  • #131: Fix an incorrect autocorrect for Rails/Presence when using [] method. ([@forresty][])
  • #142: Fix an incorrect autocorrect for Rails/EnumHash when using nested constants. ([@koic][])
  • #136: Fix a false positive for Rails/ReversibleMigration when using change_default with :from and :to options. ([@sinsoku][])
  • #144: Fix a false positive for Rails/ReversibleMigration when using change_table_comment or change_column_comment with a :from and :to hash. ([@DNA][])

Changes

  • #156: Make Rails/UnknownEnv cop aware of Rails.env == 'unknown_env'. ([@pocke][])
  • #141: Change default of EnforcedStyle from arguments to slashes for Rails/FilePath. ([@koic][])
Commits
  • f297ebd Cut 2.4.1
  • cbc0673 Merge pull request #168 from fidalgo/ignore-db-schema-and-bin-directory
  • 5f60b16 Merge pull request #174 from ngan/relative_date_example
  • 9e239be Merge pull request #172 from koic/move_line_length_cop_to_layout_department
  • 703f18e Add another good example for RelativeDateConstant
  • 8dd305c Merge pull request #171 from koic/suppress_ruby_27_real_kwargs_warning
  • b1756fe [Fix #166] Ignore db/schema and bin
  • 22e595d Move LineLength cop from Metrics to Layout department
  • 2d37a0d Suppress a deprecation warning when using Ruby 2.7.0-dev
  • f9224f9 Merge pull request #170 from mvz/make-bulk-change-table-handle-blocks
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@pgwillia pgwillia self-assigned this Jan 3, 2020
In the gem bump for rubocop-rails to 2.4.1 the default EnforcementStyle
changed from arguments to slashes.  That means that
`Rails.root.join('config', 'controlled_vocabularies', '*.yml')` becomes
`Rails.root.join('config/controlled_vocabularies/*.yml')`.  It was
[previously thought](rubocop/rubocop-rails#128 (comment))
that the first way was OS agnostic but it turns out that Rails.root is a
Pathname instance which accounts for this.  Now the slash is prefered for
fewer strings/arguments.
@pgwillia pgwillia force-pushed the dependabot/bundler/rubocop-rails-2.4.1 branch from 97c34c8 to 1d40c02 Compare January 3, 2020 17:58
@pgwillia pgwillia requested a review from lagoan January 3, 2020 17:59
Copy link
Contributor

@lagoan lagoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

@lagoan lagoan merged commit aa743ff into integration_postmigration Jan 3, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubocop-rails-2.4.1 branch January 3, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants