Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in Danger: https://danger.systems/ruby/ #998

Closed
murny opened this issue Jan 25, 2019 · 0 comments
Closed

Bring in Danger: https://danger.systems/ruby/ #998

murny opened this issue Jan 25, 2019 · 0 comments

Comments

@murny
Copy link
Contributor

murny commented Jan 25, 2019

Might be a fun beginner issue. We use Danger in pushmipullyu, it might be nice to add it to jupiter (and maybe other repos?)
Can help us with things like:

  • remind us if we forgot to add a CHANGELOG entry which happens alot!
  • adding tests if lots of code were being added
  • break up big PRs
  • rebase PRs if they have a ton of commits
  • adding detail descriptions etc.

A few different dangerfile examples in the wild:
https://github.com/discourse/discourse/blob/master/Dangerfile
https://github.com/capistrano/danger/blob/master/Dangerfile

and ours from pushmipullyu:
https://github.com/ualbertalib/pushmi_pullyu/blob/master/Dangerfile

And the PR for adding this to pushmipullyu: ualbertalib/pushmi_pullyu#61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants