Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Logic from SearchController into ItemSearch Concern #932

Closed
murny opened this issue Nov 27, 2018 · 1 comment
Closed

Move Logic from SearchController into ItemSearch Concern #932

murny opened this issue Nov 27, 2018 · 1 comment
Assignees
@murny
Labels
8 pre-phase2-infrastructure technical-debt

Comments

@murny
Copy link
Contributor

murny commented Nov 27, 2018

Issue discovered and explained in #931 (comment)

SearchController logic should be moved into ItemSearch Concern so all item search pages (items, collections, and users) can receive and share the same logic everywhere.

Thus we could handle range limit better, by keeping them on the originating page, instead of redirecting them off to the /search page instead.
@mbarnett mbarnett mentioned this issue Apr 24, 2020
Open
@mbarnett mbarnett added the 8 label May 4, 2020
@murny murny self-assigned this May 13, 2020
@murny murny mentioned this issue May 20, 2020
Merged
@murny
Copy link
Contributor Author

murny commented Jun 5, 2020

This has been merged. Closing issue

@murny murny closed this as completed Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@murny murny

Labels
8 pre-phase2-infrastructure technical-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbarnett @murny