Add tests for Controllers

[murny]

Some of our controllers are missing tests (DownloadsController and ItemsController are probably the two biggest but there is a bunch of others here (profiles/robots/static pages/etc))

We should be testing these actions and verifying they are coming back with the proper responses (in DownloadsController case, are the proper disposition and content_type headers set properly?).

[ConnorSheremeta]

It appears as though DownloadsController has had tests added already (although simplecov is still showing 0% coverage for downloads_controller.rb for some reason.) Would it be safe to assume that this issue can be closed?

[pgwillia]

Yeah, looks like the tests for downloads controller were added the day after the issue was created. 2b814d4

There are differences to coverage/index.html after running bundle exec rails test and bundle exec rails test:system

Download Controller looks good

There are some gaps that we could improve as part of this ticket (I've renamed it)