You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We resize our images (via activestorage/imagemagick) and set html width/height to be 350x350 for feature images and 100x100 for thumbnails. However for CSS we set a max-width/max-height for these differently as 270x350 for feature images and 135x175 for thumbnails. So not sure why these are different? We set these max widths as a solution for this issue : #661. But curious since we are forcing a resize via imagemagick if this is doing what we think it is (if the images are always going to be 100x100 or 350x350 since we resize them, then our max-width/max-height CSS will force them into different dimensions which could hurt the image quality)?
Also in Rails 6 there appears to be better/improved resize methods we should maybe look into (#resize_to_fit, #resize_to_fill)
Plenty of discussion is also captured in the above issue.
Seems from the options available to us from image_processing gem we want to covert resize to resize_to_limit in Jupiter and updated our max-width/max-height css for thumbnails/feature images.
The text was updated successfully, but these errors were encountered:
From #1690:
Main issue:
Plenty of discussion is also captured in the above issue.
Seems from the options available to us from
image_processing
gem we want to covertresize
toresize_to_limit
in Jupiter and updated our max-width/max-height css for thumbnails/feature images.The text was updated successfully, but these errors were encountered: