Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use #resize_to_limit instead of #resize for thumbnail/images in Jupiter #1698

Closed
murny opened this issue Jun 8, 2020 · 1 comment
Closed
Assignees

Comments

@murny
Copy link
Contributor

murny commented Jun 8, 2020

From #1690:

Main issue:

We resize our images (via activestorage/imagemagick) and set html width/height to be 350x350 for feature images and 100x100 for thumbnails. However for CSS we set a max-width/max-height for these differently as 270x350 for feature images and 135x175 for thumbnails. So not sure why these are different? We set these max widths as a solution for this issue : #661. But curious since we are forcing a resize via imagemagick if this is doing what we think it is (if the images are always going to be 100x100 or 350x350 since we resize them, then our max-width/max-height CSS will force them into different dimensions which could hurt the image quality)?

Also in Rails 6 there appears to be better/improved resize methods we should maybe look into (#resize_to_fit, #resize_to_fill)

Plenty of discussion is also captured in the above issue.

Seems from the options available to us from image_processing gem we want to covert resize to resize_to_limit in Jupiter and updated our max-width/max-height css for thumbnails/feature images.

@murny murny self-assigned this Jun 10, 2020
@murny
Copy link
Contributor Author

murny commented Jun 16, 2020

Should be fixed now, after #1713 PR has been merged.

@murny murny closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant