Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup any nulls on is_published_in_era columns on Draft tables and make non-nullable #1408

Closed
mbarnett opened this issue Jan 8, 2020 · 1 comment

Comments

@mbarnett
Copy link
Contributor

mbarnett commented Jan 8, 2020

For some reason we originally defined these columns as nullable, default false booleans, which has the weird side-effect of allowing nulls to creep into this column if they're written in explicitly, complicating queries that attempt to identify draft vs published records, because it has to account for this three-valued logic.

There's no real reason to allow this column to be nullable, so we need a simple migration to add a non-nullable constraint to the column

@mbarnett
Copy link
Contributor Author

Closing, since I think this got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants