Looks like sprockets v4.0.0 upgrade changed to use manifest file heav… #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ily, which was not configured correctly
murny
commented
Jan 7, 2020
| .community-collection { | ||
| .card { | ||
| // TODO: have real designer pick this | ||
| background-color: $cc-background; | ||
| background-color: $gray-100; |
There was a problem hiding this comment.
Clean this up a bit. Don't need the secondary variable and TODO isn't really relevant anymore 😅
murny
commented
Jan 7, 2020
| @@ -11,4 +11,4 @@ | |||
| # Precompile additional assets. | |||
| # application.js, application.css, and all non-JS/CSS in the app/assets | |||
| # folder are already added. | |||
| Rails.application.config.assets.precompile += %w[admin.js] | |||
| # Rails.application.config.assets.precompile += %w[admin.js] | |||
There was a problem hiding this comment.
Apparently you don't do this anymore in Sprockets v4.0.0, they want you to use manifest instead.
murny
commented
Jan 7, 2020
| @@ -1,3 +1,5 @@ | |||
| //= link_tree ../images | |||
| //= link_directory ../javascripts .js | |||
| //= link_directory ../stylesheets .css | |||
There was a problem hiding this comment.
So this is the problem. It was loading it in a order we didn't want. We want to load just the application.css file and the order that is specified by that file.
murny
commented
Jan 7, 2020
| //= link_directory ../stylesheets .css | ||
|
|
||
| //= link application.css | ||
| //= link admin.js |
There was a problem hiding this comment.
Instead of Rails.application.config.assets.precompile += %w[admin.js] we put it here
Tested both quickly by running Rails s and looking at admin section. All seems good
Generated by 🚫 Danger |
…/jupiter into Fix-Sass-undefined-var-issue
mbarnett
approved these changes
Jan 8, 2020
ConnorSheremeta
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ily, which was not configured correctly
Should fix travisCI Builds.
More info here:
https://github.com/rails/sprockets/blob/master/UPGRADING.md#manifestjs
and issue with our problem with solution here:
rails/sprockets#597