Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description/Abstract as non-mandatory field on Thesis #1357

Closed
weiweishi opened this issue Nov 18, 2019 · 2 comments
Closed

Description/Abstract as non-mandatory field on Thesis #1357

weiweishi opened this issue Nov 18, 2019 · 2 comments
Assignees
Labels

Comments

@weiweishi
Copy link
Contributor

weiweishi commented Nov 18, 2019

Is your feature request related to a problem? Please describe.
Abstract on the deposit/edit form for thesis is a mandatory field, and it's been validated and error will appear for older theses when they don't have an abstract field, and preventing modification of other fields on these records.

Question to @leahvanderjagt and @sfarnel, should we remove the validation on the edit form to allow blank abstract? The form is only used by admin users.

@sfarnel
Copy link
Member

sfarnel commented Nov 21, 2019

Thanks @weiweishi I think this would be one way of address this issue where we may well have theses with no abstract. I also think it worthwhile to consider whether we should create a model for legacy theses separately as they differ quite a bit from the ETDs

@weiweishi
Copy link
Contributor Author

We can remote the validation for theses prior to 2009. And add this as a conditional validation.

@weiweishi weiweishi added the 5 label Jan 7, 2020
@ConnorSheremeta ConnorSheremeta self-assigned this Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants