Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embargo_history to embargo removal. #1219

Closed
weiweishi opened this issue Jul 22, 2019 · 1 comment · Fixed by #1252
Closed

Add embargo_history to embargo removal. #1219

weiweishi opened this issue Jul 22, 2019 · 1 comment · Fixed by #1252
Assignees
Labels

Comments

@weiweishi
Copy link
Contributor

Is your feature request related to a problem? Please describe.
For auditing purpose, we'd like to keep a history for embargoes. We have implemented embargo_history in the data model, and have migrated the data. We should keep the embargo history for any change to embargo through the background job, or through the UI.

Describe the solution you'd like
embargo_history is an array of strings.
We can construct the text as such:
"An embargo was deactivated on DateTime_when_embargo_was_lifted. Its release date was embargo_date. Intended visibility after embargo was visibility_after_embargo"
This can apply for both elapsed embargoes lifted through the background job, as well as any modification done through the UI.

@ConnorSheremeta ConnorSheremeta self-assigned this Aug 16, 2019
@weiweishi
Copy link
Contributor Author

weiweishi commented Aug 20, 2019

Check with @leahvanderjagt to see how we should capture when the embargo is activated.
suggested text:
"An embargo was activated on DateTime_when_embargo_was_activated. Its release date will be embargo_date. Intended visibility after embargo will be visibility_after_embargo".
And what to do at the time of item deposit.
This will be a separate discussion with @leahvanderjagt and will be captured in a different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants