Batch ingest doesn't take older licenses

[weiweishi]

Describe the bug
Batch ingest failed because it errored out on validating licenses for anything that's not on this list:
https://github.com/ualbertalib/jupiter/blob/master/config/controlled_vocabularies/license.yml

Expected behavior
we should be able to batch ingest with older licenses:
https://github.com/ualbertalib/jupiter/blob/master/config/controlled_vocabularies/old_license.yml
Example batch
#1088

[pgwillia]

Looks like there is already a test for this:

jupiter/test/models/item_test.rb

Lines 211 to 223 in fdd3dad

	test 'a license must be either from the controlled vocabulary for new licenses or for old licenses' do
	item = Item.new_locked_ldp_object(license: 'whatever')
	assert_not item.valid?
	assert_includes item.errors[:license], 'is not recognized'
	item = Item.new_locked_ldp_object(license: CONTROLLED_VOCABULARIES[:license].attribution_4_0_international)
	item.valid?
	assert_not_includes item.errors.keys, :license
	item = Item.new_locked_ldp_object(license: CONTROLLED_VOCABULARIES[:old_license].attribution_3_0_international)
	item.valid?
	assert_not_includes item.errors.keys, :license
	end

[pgwillia]

And we seed data from this list too

jupiter/db/seeds.rb

Line 139 in fdd3dad

item_attributes[:license] = CONTROLLED_VOCABULARIES[:old_license].attribution_3_0_international

Asked for access to the batch to investigate further.

[pgwillia]

It looks like the ingest script only accounts for the one

jupiter/lib/tasks/batch_ingest.rake

Line 120 in fdd3dad

unlocked_obj.license = CONTROLLED_VOCABULARIES[:license].send(item_data[:license].to_sym)

[mbarnett]

Looks like the work related to this is already merged. Closing (re-open if I'm wrong).