Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCID items on search/browse page results permit download without credentials when 'download' button is clicked upon #1069

Closed
leahvanderjagt opened this issue Apr 5, 2019 · 1 comment

Comments

@leahvanderjagt
Copy link

Describe the bug
CCID items on search/browse page results permit download without credentials when 'download' button is clicked upon. There is no issue with requiring credentials for CCID protected items in item view. There is no problematic behaviour for the download button for open access items.

To Reproduce
Steps to reproduce the behavior:

  1. Search for the name linnea, you will see an photo item depicting flowers. https://era.library.ualberta.ca/items/8486ca8c-b9ce-4af9-9d30-4f1b24b2b46d or any other CCID protected item, via browse in a non-credentialed state
  2. Stay in search results.
  3. Click on the download button
  4. You will have the item download w/o any CCID prompt.

This applies to all CCID protected items, I believe, after spot checking.

Expected behavior

  1. Search for the name linnea, you will see an photo item depicting flowers in results. Stay in the search results page. (item eg. is https://era.library.ualberta.ca/items/8486ca8c-b9ce-4af9-9d30-4f1b24b2b46d) or any other CCID protected item, via browse in a non-credentialed state
  2. Click on the download button
  3. CCID prompt should result.
  4. After successful login, download begins.

Screenshots
If applicable, add screenshots to help explain your problem.

Describe computer*
Reported by both Windows and Mac desktop and laptop users.

Smartphone (please complete the following information):
Have not yet tested on mobile

@leahvanderjagt
Copy link
Author

Fixed by #1071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants