-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since version 0.9.6 react-vimeo breaks apps that use React 17 #201
Comments
it should accept both :/ Line 36 in b96b482
the idea is to let your package manager decide the best fit, so if you have @types/react@17 in your tree, it should prefer to use that. |
Hi, @goto-bus-stop Mmm, I don't know, but when installing the latest version of react-vimeo, npm install @types/react@18 instead of @types/react@17 even though React 17 and @types/react@17 are defined in the project. I can make a video with the test |
Running into a similar issue with the latest create-react-app and latest version of @u-wave/react-vimeo |
Had to manually downgrade |
Got that error too when yarn add a version > 0.9.5 |
Hi, when you use any version higher than 0.9.6 it produces the errors seen in the images. It seems that the library is no longer compatible with React 17.
The problem is related with the dependecy -> @types/react@^17.0.0, when install react-vimeo 0.9.6 this install @types/react@^18.0.0 that breaks the app.
The text was updated successfully, but these errors were encountered: