Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Europe/Kiev to Europe/Kyiv #149

Closed
z0rc opened this issue Jun 22, 2023 · 2 comments
Closed

Rename Europe/Kiev to Europe/Kyiv #149

z0rc opened this issue Jun 22, 2023 · 2 comments

Comments

@z0rc
Copy link

z0rc commented Jun 22, 2023

https://mm.icann.org/pipermail/tz-announce/2022-August/000071.html

tzdata renamed Europe/Kiev to Europe/Kyiv in 2022b release. Also link was added to preserve compatibility https://data.iana.org/time-zones/tzdb-2022b/backward.

What the process for this project to follow this change?

@z0rc
Copy link
Author

z0rc commented Jun 22, 2023

To clarify my request. tzinfo supports TZInfo::Timezone.get('Europe/Kyiv') just fine, but all test cases use Europe/Kiev. Would it be sufficient to update test cases only?

@philr
Copy link
Member

philr commented Jun 22, 2023

The only references to Europe/Kiev within tzinfo are in test fixture files. Those files were based on the 2020d release of the IANA Time Zone database. The Europe/Kiev time zone identifier is not used in the unit tests (or any code).

I've updated the test fixture files to 2023c in commit 9953fc0. That's reduced the number of references to Europe/Kiev in the test fixtures from 6 to 2 and increased the number of references to Europe/Kyiv from 0 to 6. The remaining Europe/Kiev references are because of the backwards compatible link that's still included in the IANA Time Zone database. Those will remain here until after Europe/Kiev is removed upstream (if that ever happens).

@philr philr closed this as completed Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants