Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save http_proxy env variables #134

Closed
wants to merge 1 commit into from
Closed

Conversation

fengb
Copy link

@fengb fengb commented Sep 26, 2016

This allows a proxy server spun up by hotel to refer to the generated domain names by default.

@typicode
Copy link
Owner

typicode commented Oct 1, 2016

Sounds good :)
Out of curiosity, what's your OS and the proxy you're using or is it a custom one?

@fengb
Copy link
Author

fengb commented Oct 10, 2016

I'm using OS X but I added manual proxy servers into hotel and forgot to update the env variables. I think this default would be helpful for others.

(Of course, node.js core doesn't support http_proxy so that'll cause some confusion... ref: nodejs/node#8381)

@fengb
Copy link
Author

fengb commented Oct 10, 2016

Tangentially related: would it make sense to add a hotel env command to spit these out for shell exporting? e.g. eval $(hotel env)

@typicode
Copy link
Owner

Thank you for the reply. I've not thought about eval $(hotel env) but it's a nice idea. I wonder if there are any limitations to this approach compared to passing HTTP_PROXY env directly.

@typicode
Copy link
Owner

I've modified the way apps are started so that they all get HTTP_PROXY env, so there's no need to add these variables in each conf.

#142

@typicode typicode closed this Oct 29, 2016
@fengb
Copy link
Author

fengb commented Nov 1, 2016

Neat, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants