Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GooglePhoneLib overhead is extreme #410

Closed
mandymozart opened this issue Aug 21, 2019 · 4 comments
Closed

GooglePhoneLib overhead is extreme #410

mandymozart opened this issue Aug 21, 2019 · 4 comments

Comments

@mandymozart
Copy link

I would like to recommend to be using a different library or make this dependency optional.

For example:
https://github.com/catamphetamine/libphonenumber-js
is a solid rewrite with a significant size reduction.

I don't use the phone number validator at all, but I would have to fork class-validator to reduce my package size dramatically. See my package analysis:

Screenshot 2019-08-21 at 12 15 57

@stepanh
Copy link

stepanh commented Aug 21, 2019

Yes, this is gigantic.
I'd actually like to exclude class-validator from my frontend bundle altogether and only use it on the backend. Is there something like typeorm-model-shim for class-validator?

@vlapo
Copy link
Contributor

vlapo commented Aug 22, 2019

Duplicate of #248. I am working on it Please be patient.

@vlapo vlapo closed this as completed Aug 22, 2019
@jbjhjm
Copy link

jbjhjm commented Aug 26, 2019

@porschuetz @stepanh If you didn't see, Djaler posted a workaround for everyone using webpack:
#258 (comment)

@lock
Copy link

lock bot commented Sep 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants