Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IsObject and IsNotEmptyObject new decorators #334

Merged
merged 4 commits into from
Oct 2, 2019

Conversation

yogevlahyani
Copy link
Contributor

No description provided.

@vlapo
Copy link
Contributor

vlapo commented Jul 21, 2019

Could you please update docs?

@vlapo vlapo changed the title IsObject & IsNotEmptyObject new Decorators feat: add IsObject and IsNotEmptyObject new decorators Jul 21, 2019
Copy link
Contributor

@vlapo vlapo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update docs? Also take a note about arrays as array is also object in JS.

@yogevlahyani
Copy link
Contributor Author

@vlapo I will update docs this weekend and make an extra tests cases covering other objects like array, null etc..

@vlapo vlapo added this to the 0.10.1 milestone Jul 26, 2019
@yogevlahyani
Copy link
Contributor Author

@vlapo PTAL 😃

@vlapo vlapo modified the milestones: 0.10.1, 0.10.2 Sep 25, 2019
@vlapo vlapo merged commit 0a41aeb into typestack:master Oct 2, 2019
@vlapo
Copy link
Contributor

vlapo commented Oct 2, 2019

Thank you!

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants