-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply custom constraint class validation to each item in the array #295
Conversation
@pleerock Hi! Please review. |
@pleerock @NoNameProvided please find a minute to review this. |
@pleerock @NoNameProvided |
works like magic, please merge |
@vlapo ping! |
@pleerock @NoNameProvided @vlapo this PR is waiting for review for several months and currently has conflicts with recent code. I'm ready to resolve those, but not sure if it makes sense and somebody is going to review the PR. |
@NoNameProvided Please take a look at @zd333's PR. It definitely solves this issue. |
Hey @zd333, sorry for such delay. Could you please rebase and I will review PR. Thank you for your patient. |
@vlapo rebased. |
Looks good. Tests are green, code looks really good. Again, thank you for your endurance. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
When
@Validate
+ some custom constraint class is used with{ each: true }
, then it is expected to be applied to each item of the target object field:#260