-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): add quotes [extension] #762
feat(eslint-plugin): add quotes [extension] #762
Conversation
5789ece
to
f74f9d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few very minor nits, otherwise code looks good to me!
Could you please add the rule name to this Set
here and regenerate the configs:
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/tools/generate-configs.ts#L21-L32
Thanks for doing this!
f74f9d3
to
d85c1d5
Compare
@bradzacher added changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you
Would be great to have that merged and released! Just stumbled upon the initial issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @a-tarasyuk!
Codecov Report
@@ Coverage Diff @@
## master #762 +/- ##
==========================================
+ Coverage 94.13% 94.15% +0.02%
==========================================
Files 112 113 +1
Lines 4843 4860 +17
Branches 1347 1351 +4
==========================================
+ Hits 4559 4576 +17
Misses 163 163
Partials 121 121
|
Since typescript-eslint/typescript-eslint#762 is published the normal quotes rule can be disabled and the typescript one activated. This allows me to use backticks, but they won’t get added to types (they are not valid there)
Hi @JamesHenry @a-tarasyuk export = ... You must use import moment = require('moment'); // real life example to import them, and the rule alerts on those, while it is not valid to use back ticks here. Do you can care to fix that as well? |
hey @regevbr - please raise a new issue instead of commenting on old PRs. |
Fixes #757
Fixes #756