-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct issues with circular imports #4140
Conversation
Thanks for the PR, @armano2! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✔️ Deploy Preview for typescript-eslint ready! 🔨 Explore the source changes: 512e520 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/6191c71df56a900008f27023 😎 Browse the preview: https://deploy-preview-4140--typescript-eslint.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #4140 +/- ##
==========================================
- Coverage 93.14% 92.70% -0.44%
==========================================
Files 157 315 +158
Lines 8251 10124 +1873
Branches 2640 2906 +266
==========================================
+ Hits 7685 9385 +1700
- Misses 192 306 +114
- Partials 374 433 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
|
PR Checklist
Overview
Ensure that we are not doing circular imports in code-base, this change has been extracted from #4108