fix(eslint-plugin): [padding-line-between-statements] TSModuleBlock should change scope

[josephzidell]

Updates the scope changes to include TSModuleBlock. This helps a module declaration be its own scope, thereby fixing false positives related to #3869

[typescript-eslint]

Thanks for the PR, @josephzidell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit b66073f. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx test @typescript-eslint/eslint-plugin-internal
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx run-many --target=typecheck --all --parallel
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/experimental-utils
	nx test @typescript-eslint/scope-manager
	nx test @typescript-eslint/visitor-keys
	nx run-many --target=build --all --parallel
	nx test @typescript-eslint/typescript-estree
	nx run-many --target=build --all --parallel
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/experimental-utils
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/scope-manager
	nx test @typescript-eslint/experimental-utils

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #3944 (b66073f) into master (02c6ff3) will increase coverage by 0.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3944      +/-   ##
==========================================
+ Coverage   92.70%   93.51%   +0.81%     
==========================================
  Files         331      151     -180     
  Lines       11637     8143    -3494     
  Branches     3290     2582     -708     
==========================================
- Hits        10788     7615    -3173     
+ Misses        371      167     -204     
+ Partials      478      361     -117     

Flag	Coverage Δ
unittest	93.51% <ø> (+0.81%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...lugin/src/rules/padding-line-between-statements.ts	91.09% <ø> (ø)
packages/visitor-keys/src/visitor-keys.ts
packages/scope-manager/src/lib/es6.ts
...escript-estree/src/semantic-or-syntactic-errors.ts
packages/experimental-utils/src/json-schema.ts
...ackages/experimental-utils/src/ts-eslint/Linter.ts
.../experimental-utils/src/ts-eslint-scope/analyze.ts
packages/scope-manager/src/lib/esnext.weakref.ts
packages/eslint-plugin-tslint/src/custom-linter.ts
packages/scope-manager/src/lib/es2015.proxy.ts
... and 171 more

[bradzacher]

thanks for being a champion and fixing this!