-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [prefer-readonly-parameter-types] add option treatMethodsAsReadonly #3733
feat(eslint-plugin): [prefer-readonly-parameter-types] add option treatMethodsAsReadonly #3733
Conversation
Thanks for the PR, @RebeccaStevens! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
7abd090
to
af4fa36
Compare
Codecov Report
@@ Coverage Diff @@
## master #3733 +/- ##
==========================================
- Coverage 93.55% 92.68% -0.87%
==========================================
Files 147 327 +180
Lines 7869 11354 +3485
Branches 2493 3202 +709
==========================================
+ Hits 7362 10524 +3162
- Misses 162 369 +207
- Partials 345 461 +116
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cd96b27
to
205f5e6
Compare
…atMethodsAsReadonly fix typescript-eslint#1758
205f5e6
to
af431ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this!
fix #1758