fix(typescript-estree): correct AST regression introduced by TS4.0 upgrade #2316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: prettier/prettier#8805
I had a major brainfart when implementing #2305 and didn't think about the fact that changes should be backwards compatible.
When handling the null type change introduced by
4.0
, I deleted the old branches instead of gating them behind a version check. This PR just gates the old logic for< 4.0
.We don't have automated testing against old TS versions yet (#1752) so I tested this by hand by doing the following:
yarn build
to build against4.0.0-beta
.3.9.7
yarn install --ignore-scripts
(the automatic rebuild after the install would fail due to incorrect types)cd packages/typescript-estree && yarn test ast-fixtures
cc @thorn0 / @fisker