fix(parser): fix regression with no-unused-vars for jsx attributes #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
added
bug
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
=======================================
Coverage 95.76% 95.76%
=======================================
Files 50 50
Lines 2526 2526
Branches 373 373
=======================================
Hits 2419 2419
Misses 63 63
Partials 44 44
|
JamesHenry
approved these changes
Jan 29, 2019
|
Would it be possible to release a patch version with this fix? The monorepo prevents us to easily depend on |
|
We publish a canary release after every successful merge, so you can
install that from npm until the latest tag is updated
…On Wed, 30 Jan 2019 at 07:24, William Durand ***@***.***> wrote:
Would it be possible to release a patch version with this fix? The
monorepo prevents us to easily depend on master
<npm/npm#2974> (or any other commit/tag/branch)
in the package.json file.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA29q_-jrXtDVQv7RuR0PX-ODS6Tsocnks5vIY7qgaJpZM4aY6bf>
.
|
|
@willdurand I have also now added this information to the README - https://github.com/typescript-eslint/typescript-eslint#package-versions |
Oh cool! Thanks! I tried a few tags but did not think about |
|
It's just lerna's convention for it
…On Wed, Jan 30, 2019 at 8:47 AM William Durand ***@***.***> wrote:
@willdurand <https://github.com/willdurand> I have also now added this
information to the README -
typescript-eslint/typescript-eslint#package-versions
<https://github.com/typescript-eslint/typescript-eslint#package-versions>
Oh cool! Thanks! I tried a few tags but did not think about canary 👌
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA29qxzQx2qEqT5fzYvHTApq42lAzb_Uks5vIaJXgaJpZM4aY6bf>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes regression with visiting jsx attributes, and adds tests cases for it.
fixes: #160