-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typescript-estree): parsing of deeply nested new files in new folder #1412
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #1412 +/- ##
==========================================
+ Coverage 94.58% 94.58% +<.01%
==========================================
Files 140 140
Lines 6057 6058 +1
Branches 1723 1723
==========================================
+ Hits 5729 5730 +1
Misses 181 181
Partials 147 147
|
**
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one suggestion, just to better integrate it
- this commit should fail to build (fix is commented out)
**
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, great work figuring out this hard to repro bug.
thanks so much!
Context:
Currently
**
is resolved only as directory, it means that for./**/*
paths/src/test.ts
,/test.ts
is going to work but/src/test/test.ts
will not.This is edge case and happens when you setup includes with
**
.Config example:
fixes #1394