feat(eslint-plugin): [no-unnec-cond] support nullish coalescing #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @Retsam! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
The rule will now check that the left-hand side of the ?? operator is potentialy nullish, not potentially falsy.
Adds an error for the case where the left-hand side of `??` is always null or undefined
Retsam
force-pushed
the
support-unnecessary-nullish
branch
from
a2bcfae
to
a04eba3
Compare
5 tasks
bradzacher
approved these changes
Nov 30, 2019
Codecov Report
@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
+ Coverage 93.99% 94.01% +0.01%
==========================================
Files 131 131
Lines 5778 5797 +19
Branches 1631 1638 +7
==========================================
+ Hits 5431 5450 +19
Misses 186 186
Partials 161 161
|
bradzacher
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
??operator to theno-unnecessary-conditionrule - it will check that the left-hand side of that operator is potentially nullish (as well as potentially non-nullish).(Related, #1052)