-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typescript-estree): check TTY before version mismatch warning #1121
Conversation
Thanks for the PR, @FabioAntunes! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also add this to typescript-estree
?
Codecov Report
@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
+ Coverage 94.07% 94.07% +<.01%
==========================================
Files 120 120
Lines 5212 5213 +1
Branches 1442 1443 +1
==========================================
+ Hits 4903 4904 +1
Misses 177 177
Partials 132 132
|
Hey @bradzacher, that's what I did on this PR |
Oh my. Sorry, I completely misread the file path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this
Currently the Warning regarding the versions mismatch breaks other tools, like ALE for vim.
Since some tools depend on the output to the stdout to be a well formatted json.
This fixes the issue by allowing tools to use the parser without getting the warning, but still displaying the warning if the user triggers the command from the terminal.
Fixes #1060