fixes 4753 #4826
Merged
fixes 4753 #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruscon
reviewed
Sep 29, 2019
|
|
||
| // validate all created entity metadatas to make sure user created entities are valid and correct | ||
| entityMetadataValidator.validateMany(this.entityMetadatas.filter(metadata => metadata.tableType !== "view"), this.driver); | ||
| } | ||
|
|
||
| // This database name property is nested for replication configs. | ||
| protected getDatabaseName(): string { | ||
| const options = this.options; |
There was a problem hiding this comment.
const {replication, database} = this.options;
// ...There was a problem hiding this comment.
This causes an issue with the typeguard. I can't be sure this.options contains replication until after the guard. I was trying to avoid the use of any. I like destructuring, but don't think it's worth the cost here.
|
Thanks @elthrasher so much! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #4753 and also provide a better way to actually get the database name.