Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should AppliedFragment Monoid use spaces? #1110

Open
matthughes opened this issue Jul 22, 2024 · 0 comments
Open

Should AppliedFragment Monoid use spaces? #1110

matthughes opened this issue Jul 22, 2024 · 0 comments

Comments

@matthughes
Copy link
Contributor

matthughes commented Jul 22, 2024

When combining AppliedFragments, should we intercalcate a space? I think technically that would violate the Monoid rules but I think that is what callers would want 99% of the time.

  /** `AppliedFragment` is a monoid. */
  implicit val MonoidAppFragment: Monoid[AppliedFragment] =
    new Monoid[AppliedFragment] {
      def combine(x: AppliedFragment, y: AppliedFragment): AppliedFragment = x |+| y
      def empty: AppliedFragment = AppliedFragment.empty
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant