Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties.overrideParameters doesn't work as expected #289

Closed
alexandrnikitin opened this issue Oct 27, 2016 · 3 comments
Closed

Properties.overrideParameters doesn't work as expected #289

alexandrnikitin opened this issue Oct 27, 2016 · 3 comments

Comments

@alexandrnikitin
Copy link
Contributor

Properties.overrideParameters method gets called but doesn't override parameters.
A piece of code to reproduce:

import org.scalacheck.Test.Parameters
import org.scalacheck._

object StringSpecification extends Properties("String") {
  import Prop.forAll

  override def overrideParameters(p: Parameters): Parameters = {
    println("called")
    p.withMinSuccessfulTests(1) // this doesn't affect number of iterations
  }

  property("startsWith") = forAll { (a: String, b: String) =>
    println("iteration")
    (a+b).startsWith(a)
  }

}

Related to #234 but it didn't get called before this PR.

@ljwagerfield
Copy link

Has anyone found a solution / workaround to this?

@ashawley
Copy link
Contributor

@ljwagerfield See #360 where this was more recently picked up

@ashawley
Copy link
Contributor

Closing this issue. A fix for overriding the parameters of properties was merged in #522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants