Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is artifact upload necessary for PRs? #89

Closed
armanbilge opened this issue Jan 22, 2022 · 0 comments · Fixed by #91
Closed

Is artifact upload necessary for PRs? #89

armanbilge opened this issue Jan 22, 2022 · 0 comments · Fixed by #91

Comments

@armanbilge
Copy link
Member

This was a default inherited from sbt-gh-actions/sbt-spiewak, but as pointed out in typelevel/shapeless-3#63 (comment) it seems unnecessary for PRs. If it's not, we can add a conditional to skip it for PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant