Add 'spanId' to Trace interface #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
May 14, 2023
Add `Applicative` constraint to new `spanId` field in interface to provide default for backwards compatibility. Co-authored-by: Arman Bilge <[email protected]>
|
Nice one Greg! I need this and I was about to make an identical PR. |
|
@armanbilge Any chance to get this approved? Or someone else I should ping? |
Does this actually compile for you? |
Oof, no, sorry! I just assumed the recommended change would be enough. I'll work on getting this ready! |
|
Ok, good to go now! |
|
@armanbilge Sorry to ping again but this is ready for review! |
armanbilge
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
spanIdwas omitted from theTrace[F]interface, probably by accident? According to this section of the docs, it should be accessible from the ambient spans using theTraceeffect.