accept optional arbitrary fields when attaching an error to a span #694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, it's still possible to attach arbitrary fields onto an event using
log
(or onto a span itself usingput
), but for at least the OpenTelemetry backend, that results in the exception being placed on a distinct event on the span from the other fields. Keeping them together seems more semantically sound.If this is merged, I plan to use it here in log4cats-natchez. That line would probably become something like
Arguably, we could also make a very similar addition to the
def log(event: String): F[Unit]
method, but I think it's less necessary there because AFAICT, for most of the backends, you can achieve the same result by usingdef log(fields: (String, TraceValue)*): F[Unit]
and adding an"event" -> TraceValue.StringValue(event)
with the rest of the attributes being set.