Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate feral-lambda with otel4s #340

Open
armanbilge opened this issue Apr 16, 2023 · 4 comments
Open

Integrate feral-lambda with otel4s #340

armanbilge opened this issue Apr 16, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@armanbilge
Copy link
Member

Building on #339, we can then integrate otel4s directly into IOLambda, following these additional semantic conventions:

@armanbilge armanbilge added the enhancement New feature or request label Apr 16, 2023
@alexcardell
Copy link

@armanbilge I am happy to have a go at this, given the otel4s SDK looks to land soon

What are your thoughts on pulling out a natchez module, and supporting both for the near term?

@armanbilge
Copy link
Member Author

What are your thoughts on pulling out a natchez module, and supporting both for the near term?

This seems like a smart idea, nice! I see you already got a PR up. @bpholt wdyt?

@bpholt
Copy link
Member

bpholt commented Feb 23, 2024

Sounds like a great idea to me! Thanks for submitting the PR @alexcardell.

@alexcardell
Copy link

The module on its own doesn't seem valuable and an unnecessary breaking change, I've closed it for now and included it in #459

Up to you guys if you want to reopen and include it in the next breaking, then the otel4s module could be a patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants