Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elide thunk allocation when using sleepInternal #3775

Merged
merged 2 commits into from
Aug 6, 2023
Merged

Elide thunk allocation when using sleepInternal #3775

merged 2 commits into from
Aug 6, 2023

Conversation

armanbilge
Copy link
Member

The Scheduler interface promises a Runnable for cancelation but we ultimately wrap it in an IO.Delay which expects a Function0. By implementing both Function0 with Runnable we can elide the wrapper allocation.

@armanbilge armanbilge merged commit ead57bc into typelevel:series/3.5.x Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durban durban durban approved these changes

Assignees
No one assigned
Labels
🍄 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armanbilge @durban